Show offers in dstack apply for elastic container fleets#3754
Merged
peterschmidt85 merged 3 commits intomasterfrom Apr 10, 2026
Merged
Show offers in dstack apply for elastic container fleets#3754peterschmidt85 merged 3 commits intomasterfrom
peterschmidt85 merged 3 commits intomasterfrom
Conversation
Use run-capable offer lookup for cloud fleets with nodes.min=0 and nodes.target=0, while keeping create-instance filtering for non-elastic fleets.\n\nAdds router tests for elastic container backend offers and preserves no-offers behavior for non-elastic container fleets.
r4victor
reviewed
Apr 8, 2026
r4victor
reviewed
Apr 8, 2026
r4victor
reviewed
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Expected
dstack applyshould show matching offers for elastic container-based fleets, since runs are provisioned on demand from those offers.This is important not only for offer visibility/convenience, but also for consistency: VM-based elastic fleets already show offers during
apply, and container-based elastic fleets should behave the same way.Actual
No offers were shown for elastic container-based fleets during
apply, even when offers existed.Solution
Refactored fleet offer semantics to avoid duplicating branches while preserving behavior:
get_fleet_offers(...)as the shared offer lookup for fleet planning/provisioning.get_fleet_offers(...)defaults to filtering byBACKENDS_WITH_CREATE_INSTANCE_SUPPORT.get_create_instance_offers(...); create-instance paths now callget_fleet_offers(...)withinclude_only_create_instance_supported_backends=Trueexplicitly.get_plan(...), whennodes.target == 0, we callget_fleet_offers(...)with create-instance filtering disabled, so elastic Runpod/container offers are shown._is_elastic_cloud_fleet_spec(...)helper and switched to directnodes.targetsemantics.This keeps non-elastic behavior unchanged while fixing elastic container fleet offer visibility in
dstack apply.AI Assistance
This PR was prepared with AI assistance (Codex).